Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NumPy >= 2.1 #567

Open
Francis-dev82 opened this issue Sep 5, 2024 · 5 comments
Open

Add support for NumPy >= 2.1 #567

Francis-dev82 opened this issue Sep 5, 2024 · 5 comments
Labels
numpy compatibility Affects compatibility with NumPy

Comments

@Francis-dev82
Copy link

No description provided.

@mhostetter mhostetter added the numpy compatibility Affects compatibility with NumPy label Sep 5, 2024
@Francis-dev82
Copy link
Author

Do you know if this is a big change to the code base? I am sure you have other priorities just curious what the timeline might be.

@mhostetter
Copy link
Owner

I'm sure it's just bumping the max version in pyproject.toml and submitting a PR. I could maybe do it this evening.

mhostetter added a commit that referenced this issue Sep 5, 2024
@dimbleby
Copy link

dimbleby commented Sep 7, 2024

fwiw, galois 0.4.2 still does not support numpy 2.1 - because numba 0.60 requires numpy<2.1

Also fwiw I suggest that 2.2 is an odd upper bound for this library to choose for numpy. Do you have reason to expect that 2.2 will be breaking?

I expect that in practice numba will always be the bottleneck on the numpy version that galois can use, so you might as well not bother with an upper bound at all.

@Francis-dev82
Copy link
Author

Numba is working on this. Hopefully we will know more after the developer meeting tomorrow. numba/numba#9708

@mhostetter
Copy link
Owner

fwiw, galois 0.4.2 still does not support numpy 2.1 - because numba 0.60 requires numpy<2.1

Thanks for pointing this out. I rushed to close the PR and didn't do due diligence.

Also fwiw I suggest that 2.2 is an odd upper bound for this library to choose for numpy. Do you have reason to expect that 2.2 will be breaking? I expect that in practice numba will always be the bottleneck on the numpy version that galois can use, so you might as well not bother with an upper bound at all.

I think this is a very reasonable idea. I'll incorporate that change when I add support for Numba 0.61.

@mhostetter mhostetter reopened this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
numpy compatibility Affects compatibility with NumPy
Projects
None yet
Development

No branches or pull requests

3 participants