Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micronaut 5 changes #3320

Open
dstepanov opened this issue Feb 19, 2025 · 3 comments
Open

Micronaut 5 changes #3320

dstepanov opened this issue Feb 19, 2025 · 3 comments

Comments

@dstepanov
Copy link
Contributor

Taking notes what should be changed in v5. Those are going to be breaking changes.

  • We should introduce insert method as alternative to save (which should be insert or update based on the id presence) (Adding new InsertOneInterceptor etc interceptors)
  • PagedQuery should contain all the information that can be used to produce a Page, it should have the optional select and count PreparedQuery query. Methods in RepositoryOperations <T> long count(PagedQuery<T> pagedQuery) <R> Page<R> findPage(@NonNull PagedQuery<R> query) should be more used.
  • Cleanup @DataMethod now queries (base query + optional count query) are stored as sub values
  • RepositoryOperations should return List instead of Itereable, that was changed for the repository classes but not for the operations
  • Remove old query builder on query model
  • Use Hibernate's pagination support for returning pages. We alredy use it for Cursors to support Jakarta Data
@graemerocher
Copy link
Contributor

we don't want a dependency on Hibernate from JDBC

@dstepanov
Copy link
Contributor Author

Do we have it now?

@rlconst
Copy link
Contributor

rlconst commented Feb 26, 2025

I propose to use upsert or re-purpose save method to insert or update depending on id presence. Save method bite me more than onse. Insert is clearly signalling "create a new"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants