Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use button semantics and styles for link elements that work as buttons #7700

Closed
1 task done
JasonYeMSFT opened this issue Jan 24, 2024 · 2 comments
Closed
1 task done
Assignees
Labels
:accessibility: accessibility Related to accessibility
Milestone

Comments

@JasonYeMSFT
Copy link
Contributor

JasonYeMSFT commented Jan 24, 2024

Standard to meet:

  • Elements that trigger "in-application actions" should be <button> elements. Accessibility Insights should register the element as a "button".

  • Elements that "open link in external browsers" should be <a> elements, with a blue underline. Accessibility Insights should register the element as a "link".

  • Action buttons of the renderer window notification (customized actions and the default close action)

@JasonYeMSFT JasonYeMSFT added the :accessibility: accessibility Related to accessibility label Jan 24, 2024
@MRayermannMSFT MRayermannMSFT assigned JasonYeMSFT and unassigned craxal Jan 29, 2024
@MRayermannMSFT MRayermannMSFT added the ❔ investigate We need to look into this further label Jan 29, 2024
@MRayermannMSFT MRayermannMSFT added this to the 1.34.0 milestone Jan 29, 2024
@MRayermannMSFT
Copy link
Member

In 1.34, please fill out the "Elements needing updating:" list and then we can determine how we want to triage/distribute the actual doing of this work.

@JasonYeMSFT JasonYeMSFT removed the ❔ investigate We need to look into this further label Apr 8, 2024
@JasonYeMSFT
Copy link
Contributor Author

Investigation is done for 1.34.0.

@JasonYeMSFT JasonYeMSFT modified the milestones: 1.34.0, 1.35.0 Apr 16, 2024
@richardMSFT richardMSFT modified the milestones: 1.35.0, 1.36.0 Jul 26, 2024
@craxal craxal modified the milestones: 1.36.0, 1.37.0 Aug 7, 2024
@craxal craxal changed the title Use button like styles for link elements work as buttons Use button semantics and styles for link elements that work as buttons Sep 27, 2024
@richardMSFT richardMSFT modified the milestones: 1.37.0, 1.38.0 Dec 6, 2024
@craxal craxal assigned craxal and unassigned richardMSFT Dec 18, 2024
@craxal craxal closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:accessibility: accessibility Related to accessibility
Projects
None yet
Development

No branches or pull requests

4 participants