New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in Logit Processor? #272

Open

SaeedNajafi opened this issue Sep 30, 2024 · 1 comment

Assignees

SaeedNajafi commented Sep 30, 2024

Don't you have a bug in the logit processor? It seems you don't even use the processed scores in the wrapper.

LMOps/minillm/transformers/src/transformers/generation/utils.py

Line 2942 in 96e7d9d

next_token_scores = logits_warper(input_ids, next_token_logits)

donglixp self-assigned this

Contributor

t1101675 commented Sep 30, 2024 •

edited

Loading

Thanks for pointing it out! We have fixed this issue in this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment