Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<xutility>: What's the intent of the pseudo-documentation? #5081

Open
frederick-vs-ja opened this issue Nov 12, 2024 · 1 comment
Open

<xutility>: What's the intent of the pseudo-documentation? #5081

frederick-vs-ja opened this issue Nov 12, 2024 · 1 comment
Labels
enhancement Something can be improved

Comments

@frederick-vs-ja
Copy link
Contributor

The class template _Is_checked_helper has been left unused since the initial commit on Github.

STL/stl/inc/xutility

Lines 1305 to 1306 in 25dc2b7

template <class, class = void>
struct _Is_checked_helper {}; // default definition, no longer used, retained due to pseudo-documentation

It's unclear what the "pseudo-documentation" is. Perhaps we should either improve the comment or entirely remove _Is_checked_helper.

@CaseyCarter CaseyCarter added the question Further information is requested label Nov 12, 2024
@StephanTLavavej StephanTLavavej added enhancement Something can be improved and removed question Further information is requested labels Nov 13, 2024
@StephanTLavavej
Copy link
Member

We talked about this at the weekly maintainer meeting. We believe that _Is_checked_helper should be outright removed - it's been a long time since we overhauled the checking machinery and provided a better, more-documented way for users to opt in. We doubt there was significant uptake of the old mechanism, and it's undesirable to continue providing _Is_checked_helper which could confuse users into thinking that it actually accomplishes something. Let's rip it out and see if any codebases notice. (If we they do, we could explore other options - reporting/fixing issues upstream, adding it back with an escape hatch, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

No branches or pull requests

3 participants