Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Dashboard should capture ring name from bedrock.yaml #1396

Open
2 tasks
samiyaakhtar opened this issue Apr 28, 2020 · 0 comments
Open
2 tasks

Dashboard should capture ring name from bedrock.yaml #1396

samiyaakhtar opened this issue Apr 28, 2020 · 0 comments
Labels
blocked effort - M less than one week effort enhancement New feature or request good first issue Good for newcomers low - pri

Comments

@samiyaakhtar
Copy link
Contributor

As a: developer

I want: the dashboard to display ring names I've configured in bedrock.yaml

So that: I can see the right ring name for services in the dashboard

Describe the solution you'd like:
Following the work on #1313, any branch can be associated with any ring name. Currently, the introspection script assumes that the branch name is ring name, which is going to change.

  • Similar to get-display-name, add a command that extracts ring name from bedrock.yaml for the branch that pipeline is triggered for. Perhaps bedrock ring get-ring-name?
  • Once this command is available in a bedrock-cli release, update the generated pipelines to consume this command in capturing data.

Acceptance Criteria:
Ring name is captured correctly in the dashboard

Describe alternatives you've considered:

Additional context:
#1313

Does this require updates to documentation?: Yes

@samiyaakhtar samiyaakhtar added enhancement New feature or request good first issue Good for newcomers effort - M less than one week effort labels Apr 28, 2020
@samiyaakhtar samiyaakhtar added this to the Service Introspection milestone Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked effort - M less than one week effort enhancement New feature or request good first issue Good for newcomers low - pri
Projects
None yet
Development

No branches or pull requests

2 participants