Remove redundant use of catch2

[dthaler]

Describe the bug

catch2 is sycned twice:
external\catch2
external\usersim\external\catch2

The former can be removed and just use the latter.

OS information

No response

Steps taken to reproduce bug

Clone and sync recursively

Expected behavior

catch2 should only be in one place

Actual outcome

catch2 appears twice

Additional details

No response

[agarwalishita]

Can you please assign this issue to me? @dthaler

[agarwalishita]

Hey @dthaler , since it is my first contribution, I would really appreciate your guidance and any information you can provide on this issue.

[agarwalishita]

On cloning this repo, I found out that catch2 has been synced here:
Submodule 'external/Catch2' (https://github.com/catchorg/Catch2.git) registered for path 'external/Catch2'
Cloning into 'ebpf-for-windows/external/Catch2'...

as well as

Submodule 'external/Catch2' (https://github.com/catchorg/Catch2.git) registered for path 'external/usersim/external/Catch2'
Cloning into 'ebpf-for-windows/external/usersim/external/Catch2'...

Will work on removing the former one

[dthaler]

Right, the latter (inside usersim) is needed because usersim has its own tests that use catch2, and it doesn't use other repositories that have catch2.