Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting ignore_eos for llama serverless endpoint #51

Open
vidhishanair opened this issue Nov 15, 2024 · 0 comments · May be fixed by #52
Open

Setting ignore_eos for llama serverless endpoint #51

vidhishanair opened this issue Nov 15, 2024 · 0 comments · May be fixed by #52

Comments

@vidhishanair
Copy link
Collaborator

ignore_eos: str = "false"

LlamaServerlessAzureRestEndpointModel which is used to run 405B models sets ignore_eos: str = "false" by default. This is passed to the api as a string and as a consequence it's not set correctly. This causes the model to continue post EOS and generate random tokens till max_token limit.

Fix: Need to set ignore_eos: bool = False. I have tested this fix for Calendar Planning.

We will need to test other bool flags like skip_special_tokens and use_beam_search as well. Similar str flags are there in Mistral model class too.

@nushib nushib linked a pull request Nov 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant