Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: LineParserTestApp is Broken #629

Closed
1 task done
makubacki opened this issue Feb 12, 2025 · 0 comments · Fixed by #634
Closed
1 task done

[Bug]: LineParserTestApp is Broken #629

makubacki opened this issue Feb 12, 2025 · 0 comments · Fixed by #634
Assignees
Labels
type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@makubacki
Copy link
Member

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

This change (bbfc2a2) prefixed advanced logger messages with the debug level. This was not reflected in the reference strings in LineParserTestApp. Therefore, the test currently fails with errors like the following:

INFO - Actual   - 00000000: 30 39 3A 30 36 3A 34 35-2E 30 31 32 20 3A 20 5B  *09:06:45.012 : [*
INFO - Actual   - 00000010: 49 4E 46 4F 5D 20 46 69-72 73 74 20 6E 6F 72 6D  *INFO] First norm*
INFO - Actual   - 00000020: 61 6C 20 74 65 73 74 20-6C 69 6E 65 0A           *al test line.*
INFO - Expected - 00000000: 30 39 3A 30 36 3A 34 35-2E 30 31 32 20 3A 20 46  *09:06:45.012 : F*
INFO - Expected - 00000010: 69 72 73 74 20 6E 6F 72-6D 61 6C 20 74 65 73 74  *irst normal test*
INFO - Expected - 00000020: 20 6C 69 6E 65 0A                                * line.*

Expected Behavior

LineParserTestApp should pass.

Steps To Reproduce

  1. Use Mu Plus dev/202405 branch
  2. stuart_build -c .\Platforms\QemuQ35Pkg\PlatformBuild.py TOOL_CHAIN_TAG=VS2022 Target=DEBUG --FlashRom TEST_REGEX=*TestApp*.efi RUN_TESTS=TRUE
  3. Check LineParserTestApp results

Build Environment

- OS(s): N/A
- Tool Chain(s): N/A
- Targets Impacted: Unit tests

Version Information

Commit: bbfc2a266e07c8c47de0a8cf638f3be7e1e7420b

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@makubacki makubacki added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Feb 12, 2025
@github-actions github-actions bot added the urgency:medium Important with a moderate impact label Feb 12, 2025
@makubacki makubacki removed the state:needs-triage Needs to triaged to determine next steps label Feb 12, 2025
ProjectMuBot pushed a commit that referenced this issue Feb 25, 2025
## Description

Fixes #629 

A case existed where the target buffer was not correct whenever the same
line buffer was extended (previous message overwritten).

Debug level strings could overwrite characters if a new debug level was
changed when residual characters were added to the same line buffer. To
simplify handling of strings, this change makes the phases and debug
message levels a fixed size. This is a breaking change but less error
prone.

The LineParserTestApp needed to be updated for debug level strings, so
that is done.

- [x] Impacts functionality?
- [ ] Impacts security?
- [x] Breaking change?
- [x] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

- LineParserTestApp
- Step through parsing with debugger and check variable values
- Log output

## Integration Instructions

- If any tools or code depend on exact string matches, note the change
in the debug message level and phase strings.

Signed-off-by: Michael Kubacki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant