You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change (bbfc2a2) prefixed advanced logger messages with the debug level. This was not reflected in the reference strings in LineParserTestApp. Therefore, the test currently fails with errors like the following:
INFO - Actual - 00000000: 30 39 3A 30 36 3A 34 35-2E 30 31 32 20 3A 20 5B *09:06:45.012 : [*
INFO - Actual - 00000010: 49 4E 46 4F 5D 20 46 69-72 73 74 20 6E 6F 72 6D *INFO] First norm*
INFO - Actual - 00000020: 61 6C 20 74 65 73 74 20-6C 69 6E 65 0A *al test line.*
INFO - Expected - 00000000: 30 39 3A 30 36 3A 34 35-2E 30 31 32 20 3A 20 46 *09:06:45.012 : F*
INFO - Expected - 00000010: 69 72 73 74 20 6E 6F 72-6D 61 6C 20 74 65 73 74 *irst normal test*
INFO - Expected - 00000020: 20 6C 69 6E 65 0A * line.*
## Description
Fixes#629
A case existed where the target buffer was not correct whenever the same
line buffer was extended (previous message overwritten).
Debug level strings could overwrite characters if a new debug level was
changed when residual characters were added to the same line buffer. To
simplify handling of strings, this change makes the phases and debug
message levels a fixed size. This is a breaking change but less error
prone.
The LineParserTestApp needed to be updated for debug level strings, so
that is done.
- [x] Impacts functionality?
- [ ] Impacts security?
- [x] Breaking change?
- [x] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?
## How This Was Tested
- LineParserTestApp
- Step through parsing with debugger and check variable values
- Log output
## Integration Instructions
- If any tools or code depend on exact string matches, note the change
in the debug message level and phase strings.
Signed-off-by: Michael Kubacki <[email protected]>
Is there an existing issue for this?
Current Behavior
This change (bbfc2a2) prefixed advanced logger messages with the debug level. This was not reflected in the reference strings in LineParserTestApp. Therefore, the test currently fails with errors like the following:
Expected Behavior
LineParserTestApp should pass.
Steps To Reproduce
stuart_build -c .\Platforms\QemuQ35Pkg\PlatformBuild.py TOOL_CHAIN_TAG=VS2022 Target=DEBUG --FlashRom TEST_REGEX=*TestApp*.efi RUN_TESTS=TRUE
Build Environment
Version Information
Urgency
Medium
Are you going to fix this?
I will fix it
Do you need maintainer feedback?
No maintainer feedback needed
Anything else?
No response
The text was updated successfully, but these errors were encountered: