Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercepting vmbus devices makes VTL2 RAM accessible to VTL0 #693

Open
cperezvargas opened this issue Jan 20, 2025 · 2 comments
Open

Intercepting vmbus devices makes VTL2 RAM accessible to VTL0 #693

cperezvargas opened this issue Jan 20, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request snp SNP specific bugs or features tdx TDX specific bugs or features

Comments

@cperezvargas
Copy link
Contributor

Make sure we are happy with VtlMemoryProtection::modify_vtl_page_setting and its usage. Alternatives could include setting aside RAM to use for this purpose, changing signature so memory can not be deallocated while not properly protected, always leak memory after this use so it can never be reused, etc.

There's some considerations if we should carve out special regions of the VTL2 GPA ranges so that we cannot use that ram for any other purposes. I think if we know exactly how large this would be, that would be desirable so that we can never have this reuse issue where the we could make pages accessible by VTL0 that VTL2 could later use for something else.

@cperezvargas
Copy link
Contributor Author

We are still doing this. The issue was opened to see if we can come up with a more creative way of handling this, but since we proposed this we are using it in even more places, so this is not likely something that will change soon.

@cperezvargas cperezvargas added tdx TDX specific bugs or features snp SNP specific bugs or features labels Jan 20, 2025
@chris-oo
Copy link
Member

chris-oo commented Feb 18, 2025

We should probably have intercepted VMBUS devices use private pool/not normal VTL2 memory for these DMA allocations rather than what we're doing today. This might come as part of the DMA refactoring work. However what we have today is functional and correct, just not the cleanest design.

@chris-oo chris-oo added the enhancement New feature or request label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request snp SNP specific bugs or features tdx TDX specific bugs or features
Projects
None yet
Development

No branches or pull requests

2 participants