You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The targets file includes content items in the consuming project.
If you install (for example) System.Diagnostics.DiagnosticSource (v9, say), you will notice that the content item it provides to the consuming project, is included by nuget as follows in the project's obj\[projectname].nuget.g.props:
This convention allows the consumer's custom targets to act and extend the build as needed by checking (at a minimum) the NuGetPackageId to see what items are being included by which packages.
Since Playwright is not using the default mechanism for content files inclusion, this metadata is missing, making it impossible for consumers to detect these items in a reliable way.
Expected behavior
I expect the content items to at least contain the NuGetPackageId metadata, and optionally the NuGetPackageVersion.
Actual behavior
No NuGet-related metadata is provided.
Additional context
No response
Environment
- .NET Version (TFM): net8.0/9.0
The text was updated successfully, but these errors were encountered:
kzu
added a commit
to kzu/playwright-dotnet
that referenced
this issue
Feb 21, 2025
…adata
This aligns the items with the built-in mechanism in nuget for providing content items, and enables reliable detection of these items in consuming projects.
Fixesmicrosoft#3108
kzu
linked a pull request
Feb 21, 2025
that will
close
this issue
Version
1.50.0
Steps to reproduce
The targets file includes content items in the consuming project.
If you install (for example) System.Diagnostics.DiagnosticSource (v9, say), you will notice that the content item it provides to the consuming project, is included by nuget as follows in the project's
obj\[projectname].nuget.g.props
:This convention allows the consumer's custom targets to act and extend the build as needed by checking (at a minimum) the
NuGetPackageId
to see what items are being included by which packages.Since Playwright is not using the default mechanism for content files inclusion, this metadata is missing, making it impossible for consumers to detect these items in a reliable way.
Expected behavior
I expect the content items to at least contain the
NuGetPackageId
metadata, and optionally theNuGetPackageVersion
.Actual behavior
No NuGet-related metadata is provided.
Additional context
No response
Environment
The text was updated successfully, but these errors were encountered: