Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues when requesting a backup don't provide error information #1531

Open
Charles-Gagnon opened this issue Jun 3, 2022 · 0 comments
Open
Labels

Comments

@Charles-Gagnon
Copy link
Contributor

Currently the error information provided when there's issues requesting a backup is minimal or nonexistent.

For example, try to request a backup (using BackupProvider.backup(...) from ADS for example) and give it an invalid connection URI. The call succeeds and returns a BackupResponse with a Result of false, but that's it. No error message or anything indicating what the issue was.

Note that this is mostly related to the setup being done before the task is started, if there's an issue when the task is running then the task system will report that as failed as expected.

The logic in the request handlers is the issue here - for the example above it correctly checks whether backup is "supported" but then nothing it does gives any further information about what went wrong. So if the URI was invalid, or the connection was an Azure connection for example.

https://github.com/microsoft/sqltoolsservice/blob/main/src/Microsoft.SqlTools.ServiceLayer/DisasterRecovery/DisasterRecoveryService.cs#L330

We should be giving as much information as possible back to the user - especially for extensibility APIs like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant