Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

razzle.cmd should prepend the path to the nuget.exe from our repo #1111

Closed
ThadHouse opened this issue Jun 2, 2019 · 3 comments
Closed

razzle.cmd should prepend the path to the nuget.exe from our repo #1111

ThadHouse opened this issue Jun 2, 2019 · 3 comments
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products.

Comments

@ThadHouse
Copy link

ThadHouse commented Jun 2, 2019

Attempting to build from cmd is giving the following output. Made sure the repo was in root so there was no too long of path issues.

C:\terminal>.\tools\razzle.cmd
Setting up dev environment...
WARNING: Error reading msbuild project information, ensure that your input solution or project file is valid. NETCore and UAP projects will be skipped, only packages.config files will be restored.
WARNING: NU3028: The author primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The author primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3018: The author primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The author primary signature found a chain building issue: UntrustedRoot
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The repository primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The author primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3028: The author primary signature's timestamp found a chain building issue: InvalidExtension
WARNING: NU3018: The author primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The repository primary signature found a chain building issue: UntrustedRoot
WARNING: NU3018: The author primary signature found a chain building issue: UntrustedRoot

C:\terminal>bcz
Starting build...
MSBuild auto-detection: using msbuild version '16.1.76.45076' from 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\bin'.
All packages listed in packages.config are already installed.
Building Appx...
"" C:\terminal\OpenConsole.sln /t:Clean,Build /m /p:Configuration= /p:Platform=
'""' is not recognized as an internal or external command,
operable program or batch file.

It seems weird that Platform is empty and forcing a new line in the Platform parameter.

Is there any way I can turn on more logging for these commands?

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 2, 2019
@zadjii-msft
Copy link
Member

Well something went crazy wrong before you executed bcz. Looks like nuget totally exploded trying to restore packages. Unfortunately, I'm not much of an expert in nuget, so I don't really know how to debug nuget errors....

I'd maybe try manually installing a fresh nuget, and using that to restore the packages for our repo, instead of relying on the version we ship with the repo. Looks like there are some missing certs, but I can't really tell from that message if it's a cert that's missing on your PC, or something wrong with the packages online :/

@DHowett-MSFT DHowett-MSFT added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Product-Meta The product is the management of the products. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 3, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 3, 2019
@ThadHouse
Copy link
Author

Turns out this was caused by having my Mono install in my Path, and the NuGet from that install was getting picked up, and causing the breakage.

Maybe https://github.com/microsoft/terminal/blob/master/tools/razzle.cmd#L24 should point directly to the NuGet exe rather then going through path, or put the deps path before the existing path in the line above. Don't know if either of those will break anything though.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 4, 2019
@zadjii-msft
Copy link
Member

Yea we could probably make razzle (and bcz) manually use that path. I'm not sure what kind of side-effects prepending our nuget might have, but I'd think they'd be minimal. Presumably, if you run razzle, you want to be in our dev space, not something else, so I think it'd be fine.

This wouldn't be a terribly challenging code change if someone wanted to pick it up :)

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. labels Jun 4, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Feb 9, 2021
@zadjii-msft zadjii-msft changed the title Error reading msbuild project information razzle.cmd should prepend the path to the nuget.exe from our repo Feb 9, 2021
@zadjii-msft zadjii-msft added the good first issue This is a fix that might be easier for someone to do as a first contribution label Feb 9, 2021
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products.
Projects
None yet
Development

No branches or pull requests

3 participants