Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when using VT mouse mode, click + drag mouse to top of screen scrolls terminal history #11399

Open
LuanVSO opened this issue Oct 2, 2021 · 2 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone

Comments

@LuanVSO
Copy link
Contributor

LuanVSO commented Oct 2, 2021

Windows Terminal version (or Windows build number)

1.11.2421.0

Other Software

wsl vim (using sgr mouse mode)

Steps to reproduce

launch vim with mouse mode enable
click and drag the mouse to top of screen

Expected Behavior

vim receives mouse events

Actual Behavior

vim receives mouse events and terminal history scrolls upward

vim.2021-10-01.23-58-43.mp4
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 2, 2021
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Oct 4, 2021
@zadjii-msft
Copy link
Member

Huh. I suppose, "big picture", this will be fixed when we actually add #381. We should be in the alt buffer, which won't have a scrollback at all. But there's also a decent argument that we shouldn't scroll like that when VT mouse mode is enabled at all.

@zadjii-msft zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label Oct 4, 2021
@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Discussion Something that requires a team discussion before we can proceed labels Oct 26, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 26, 2021
@zadjii-msft
Copy link
Member

Team discussion: we agree, "there's also a decent argument that we shouldn't scroll like that when VT mouse mode is enabled at all." Even further, we probably shouldn't scroll like that if there's no selection. Not sure which path is easier to implement.

@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 26, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants