Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit from dialog command leads to overriding output above #5762

Closed
ihor-sviziev opened this issue May 6, 2020 · 2 comments
Closed

Exit from dialog command leads to overriding output above #5762

ihor-sviziev opened this issue May 6, 2020 · 2 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@ihor-sviziev
Copy link

ihor-sviziev commented May 6, 2020

Environment

Windows build number: Microsoft Windows [Version 10.0.18363.815]
Windows Terminal version (if applicable): 0.11.1251.0

Steps to reproduce

  1. Open WSL Ubuntu 18.04
  2. Run command
HEIGHT=0
WIDTH=0
dialog \
    --backtitle "System Information" \
    --title "Menu" \
    --clear \
    --cancel-label "Exit" \
    --menu "Please select:" $HEIGHT $WIDTH 4 \
    "1" "Display System Information" \
    "2" "Display Disk Space" \
    "3" "Display Home Space Utilization"
  1. Press CTRL + C on your keyboard
  2. Try to see output that was shown before dialog
  3. Connect to ubuntu 18.04 machine via ssh, execute the same command
  4. Try to see output that was shown before dialog

Expected behavior

After step 4:

  • you should have a scroll
  • you should see commands that were above:
    example from Ubuntu 20.04:
    image

I would say on Ubuntu 20.04 new line appeared in the center of dialog, not the best experience, but much better than on Windows Terminal.

On Ubuntu 18.04 windows app it looks like this:

  • you should have a scroll
  • you should see commands that were above:
    image

After step 6:

  • you should have a scroll
  • you should see commands that were above:
    example from Ubuntu 20.04:
    image

In this case new line appeared just below the dialog.

On Ubuntu 18.04 Windows APP we have following:

  • you should have a scroll
  • you should see commands that were above:
    image

Actual behavior

After step 4:

  • no scroll at all
  • you can't see commands that were above
    image

After step 6:

  • scroll is present
  • you still can't see commands that were above (only ssh command you can see)
    image

Note: this issue also appeared on earlier versions. Hope it could be fixed before release 1.0 as it's really hard to use Windows Terminal in combination with scripts that using dialogs.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 6, 2020
@DHowett-MSFT
Copy link
Contributor

Thanks for the robust issue report! I think this is, unfortunately, a side effect of us not propagating the alternate buffer state to the terminal. That would make this a /dupe of #381.

(The alternate buffer would give Dialog a sandbox to kick around in that would get cleared/deleted when it was dismissed.)

@ghost
Copy link

ghost commented May 7, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed May 7, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants