Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all datasets have a plot method #2377

Open
10 tasks
adamjstewart opened this issue Oct 29, 2024 · 0 comments
Open
10 tasks

Ensure all datasets have a plot method #2377

adamjstewart opened this issue Oct 29, 2024 · 0 comments
Labels
datasets Geospatial or benchmark datasets good first issue A good issue for a new contributor to work on

Comments

@adamjstewart
Copy link
Collaborator

adamjstewart commented Oct 29, 2024

Summary

We should ensure all datasets have a plot method.

Rationale

This gives users a consistent API with which to plot and visualize data.

Implementation

The following datasets are missing a plot method:

  • EDDMapS
  • GBIF
  • iNaturalist
  • MMEarth
  • Western USA Live Fuel Moisture

Once these datasets have a plot method, we should add:

@abc.abstractmethod
def plot(...):

to GeoDataset and NonGeoDataset to make sure no new datasets are added without a plot method.

Note that we may need to add default plot methods to the following subclasses to make sure they remain useful:

Alternatives

No response

Additional information

No response

@adamjstewart adamjstewart added datasets Geospatial or benchmark datasets good first issue A good issue for a new contributor to work on labels Oct 29, 2024
@adamjstewart adamjstewart added good first issue A good issue for a new contributor to work on and removed good first issue A good issue for a new contributor to work on labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets good first issue A good issue for a new contributor to work on
Projects
None yet
Development

No branches or pull requests

1 participant