Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitmagic] Projects using bitmagic can't be build using clang 19 #41935

Closed
vasil-pashov opened this issue Nov 3, 2024 · 1 comment · Fixed by #42148
Closed

[bitmagic] Projects using bitmagic can't be build using clang 19 #41935

vasil-pashov opened this issue Nov 3, 2024 · 1 comment · Fixed by #42148
Assignees
@Cheney-W
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@vasil-pashov
Copy link

Is your feature request related to a problem? Please describe.

While the package itself can be build projects using it cannot be build. The issue is reported here and is fixed in master. Tested with clang 19.2. Older versions of bitmagic also fail the build.

Proposed solution

A new update that uses the latest master of v7.13.4 of bitmagic.

Describe alternatives you've considered

No response

Additional context

No response
@vasil-pashov vasil-pashov added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 3, 2024
@vasil-pashov vasil-pashov changed the title [bitmagic] Projects using bitmagic can't build using clang 19 [bitmagic] Projects using bitmagic can't be build using clang 19 Nov 3, 2024
@vasil-pashov vasil-pashov mentioned this issue Nov 4, 2024
Merged
5 tasks
vasil-pashov added a commit to man-group/ArcticDB that referenced this issue Nov 5, 2024
@vasil-pashov
Add custom overlay fixing clang builds for bitmagic (#1975)
940f2e7 
#### Reference Issues/PRs
Bitmagic is failing ArcitcDB builds. The issue is reported
[here](tlk00/BitMagic#76) and is fixed in
master. A ticket to port the fix into vcpkg is made
[here](microsoft/vcpkg#41935). Use custom
overlay while waiting for proper port.

#### What does this implement or fix?

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Nov 13, 2024
@Cheney-W Cheney-W mentioned this issue Nov 14, 2024
Merged
7 tasks
@Cheney-W
Copy link
Contributor

Since the upstream has not yet released a version that includes this modification, and we cannot arbitrarily switch from using the original tag system to the latest commit system, we will temporarily address this issue in vcpkg with a patch. Once the upstream releases a new version, we will update the port version and remove the patch.

grusev pushed a commit to man-group/ArcticDB that referenced this issue Nov 25, 2024
@vasil-pashov
Add custom overlay fixing clang builds for bitmagic (#1975)
a9d35a5 
#### Reference Issues/PRs
Bitmagic is failing ArcitcDB builds. The issue is reported
[here](tlk00/BitMagic#76) and is fixed in
master. A ticket to port the fix into vcpkg is made
[here](microsoft/vcpkg#41935). Use custom
overlay while waiting for proper port.

#### What does this implement or fix?

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cheney-W Cheney-W

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bitmagic] fixed clang compilation issues Cheney-W/vcpkg
2 participants
@vasil-pashov @Cheney-W