From 1fec88a0a63df190caf637357740919de96f75cb Mon Sep 17 00:00:00 2001
From: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Date: Sat, 1 Feb 2025 09:28:16 -0800
Subject: [PATCH] Fix typo, use more specific type

---
 .../services/suggest/browser/simpleCompletionItem.ts       | 7 +++++--
 .../services/suggest/browser/simpleCompletionModel.ts      | 6 +++---
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/vs/workbench/services/suggest/browser/simpleCompletionItem.ts b/src/vs/workbench/services/suggest/browser/simpleCompletionItem.ts
index 5bfb52723431f..b1301167f1a00 100644
--- a/src/vs/workbench/services/suggest/browser/simpleCompletionItem.ts
+++ b/src/vs/workbench/services/suggest/browser/simpleCompletionItem.ts
@@ -74,7 +74,10 @@ export class SimpleCompletionItem {
 	 */
 	readonly labelLowNormalizedPath: string;
 
-	readonly unscorePenalty: number = 0;
+	/**
+	 * A penalty that applies to files or folders starting with the underscore character.
+	 */
+	readonly underscorePenalty: 0 | 1 = 0;
 
 	/**
 	 * The file extension part from {@link labelLow}.
@@ -112,7 +115,7 @@ export class SimpleCompletionItem {
 			if (completion.isDirectory) {
 				this.labelLowNormalizedPath = this.labelLowNormalizedPath.replace(/\/$/, '');
 			}
-			this.unscorePenalty = basename(this.labelLowNormalizedPath).startsWith('_') ? 1 : 0;
+			this.underscorePenalty = basename(this.labelLowNormalizedPath).startsWith('_') ? 1 : 0;
 		}
 	}
 }
diff --git a/src/vs/workbench/services/suggest/browser/simpleCompletionModel.ts b/src/vs/workbench/services/suggest/browser/simpleCompletionModel.ts
index 4e59fc802e897..4031bba7bae30 100644
--- a/src/vs/workbench/services/suggest/browser/simpleCompletionModel.ts
+++ b/src/vs/workbench/services/suggest/browser/simpleCompletionModel.ts
@@ -215,9 +215,9 @@ export class SimpleCompletionModel {
 				}
 			}
 
-			// Sort by unscore penalty (eg. `__init__/` should be penalized)
-			if (a.unscorePenalty !== b.unscorePenalty) {
-				return a.unscorePenalty - b.unscorePenalty;
+			// Sort by underscore penalty (eg. `__init__/` should be penalized)
+			if (a.underscorePenalty !== b.underscorePenalty) {
+				return a.underscorePenalty - b.underscorePenalty;
 			}
 
 			// Sort by folder depth (eg. `vscode/` should come before `vscode-.../`)