-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing TextEditorOptions.indentSize
API type
#168836
Labels
bug
Issue identified by VS Code Team member as probable bug
candidate
Issue identified as probable candidate for fixing in the next release
regression
Something that used to work is now broken
verified
Verification succeeded
Milestone
Comments
alexdima
added
the
candidate
Issue identified as probable candidate for fixing in the next release
label
Dec 12, 2022
Closed
3 tasks
alexdima
added a commit
that referenced
this issue
Dec 13, 2022
… configured to be equal to `tabSize` (#168836)
To reproduce, you can use the following settings:
And then the following extension:
{
"name": "168836",
"publisher": "alex",
"version": "1.0.0",
"engines": {"vscode": "^1.22.0"},
"main": "main.js",
"activationEvents": ["*"]
}
const vscode = require('vscode');
exports.activate = function(context) {
setTimeout(() => {
console.log(`SETTING tabSize to 4`);
vscode.window.activeTextEditor.options.tabSize = 4;
}, 3000);
} |
Fixed by #168986 |
Is adding Edit: Ah, I just found the proposed API |
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this issue
Dec 14, 2022
… configured to be equal to `tabSize` (microsoft#168984) Updating `tabSize` should also update `indentSize` if `indentSize` is configured to be equal to `tabSize` (microsoft#168836)
2 tasks
R3CM90C7F9W |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Issue identified by VS Code Team member as probable bug
candidate
Issue identified as probable candidate for fixing in the next release
regression
Something that used to work is now broken
verified
Verification succeeded
Setting the
TextEditorOptions.tabSize
setting in an extension behaves differently since the introduction of the newindentSize
setting, as it only sets the tab size and not anymore the indent size, which, as I understand it, is intended behavior (#168745). Now, there is noindentSize
property on theTextEditorOptions
interface, ignoring TypeScript and setting it anyway does work though.This currently affects the EditorConfig extension. See editorconfig/editorconfig-vscode#341 (comment)
The text was updated successfully, but these errors were encountered: