-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement macos file picker using native APIs in the app rather than calling out to osascript #1492
Comments
@Hixie I'll be able to tackle this myself, after fixing up a large part of the platform interface. |
Probably one of #1145 and this should be closed, since they seem to be describing the same thing. |
I'll keep this one open, since the title signifies better what is meant to be done in my opinion. |
No update since April. Is anybody working on this or is this stale? |
Remember to "upvote" the issue by giving a 👍 |
I've started method channel-based implementation for now and was wondering if this would be accepted approach? Or would you rather use something like ffi? |
I think a method channel implementation is fine. The API's are Future based anyway. Thanks for tackling this! |
Just opened a PR here, happy to receive a review now |
The current approach results in this weird UI experience where the file picker isn't focused correctly, and where there's a new system process for the dialog that is separate from the actual app. It also runs into problems if osascript is disabled for some reason (e.g. security policy).
There doesn't seem to be any reason why we could implement this using regular message channels to code implemented natively in the app, like a normal plugin.
The text was updated successfully, but these errors were encountered: