Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design a mechnism for sharing uniform inputnode between the shader unform provider #56

Open
mikialex opened this issue Sep 25, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@mikialex
Copy link
Owner

Obviously global uniform map in engine is a bad design. Engine hold a camera that maintain the global map is a bad design too. As we cant share the uniform input node between the uniform decorator, so Its a workaround.

Camera should be a shadergraph decorator that decorate the vertex graph with it s projection matrix. But the uniform should could be used by other decorator/ provider. Maybe a solution is design a shared uniform map in shadergraph, just like engine's, but not as global as that.

To decoupling the name resolve issues. We can just define the related name on their static porperty. KISS

@mikialex mikialex added the enhancement New feature or request label Sep 25, 2019
@mikialex
Copy link
Owner Author

mikialex commented Oct 2, 2019

impled , but still have space for improve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant