Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to re-estimate Smaps if trajectory changes during training #168

Open
chaithyagr opened this issue Jul 25, 2024 · 2 comments
Open
Labels
feature request New feature or request

Comments

@chaithyagr
Copy link
Member

We need a way to update the smaps internally while learning k-space trajectory.
This can get complicated and it is worth starting a discussion on this.

Basically, we need a way to estimate and update Smaps internally in between forward.op, which is calibrationless fourier operator and fourier_op.adj_op, which is a self-calibrated fourier operator..

@paquiteau
Copy link
Member

Well, for sustainin the discussion, my questions are:

  • Do we really want to do that ?
    From my understanding, the smaps have very low-frequency supports, and the center of k-space is not what's changing the most during trajectory learning (?)

  • Also, if (when) we support autodiff for the smaps as well (I think that is of some interest for @AsmaTANABEN ) how would we organize this ?

  • I didn't understand your last point , could you provide some pseudo code to clarifies things a bit ?

@chaithyagr
Copy link
Member Author

  • Yes, for non-Cartesian sampling in center of k-space. We need to re-estimate. The question is how do we do it right, esp as we need kspace_data to estimate smaps . Ideally we dont need this issue and we can expect users to actually have do it right themselves.
  • We potentially wont need autodiff wrt Smaps anytime soon
  • Well:
fourier_op.samples = new_samples
forward_op.samples = new_samples
Y = forward.op(multi_image) # to simulate the scanner, so we give multi channel image as input
update_smaps(fourier_op, Y)
recon = fourier.adj_op(Y)

@paquiteau paquiteau added the feature request New feature or request label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants