-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get a new flow to normalize density compensators #231
Comments
you are right, the normalizatoin wrt to the psf/energy requires a fourier op. A solution could be to have a This way the density is normalize with the same backend that is used for the computations. Another solution is to put this normalization in the |
I like the idea of the setter function, but it could potentially make the code harder to read. Esp, right now the call to the setter is anyway only needed when the trajectory is updated and in that case the I think we are on same page for the stuff which need's For example, if we do |
My point is that if the normalization only makes sense with respect to a specific operator, it should be embedded in it. Getting sure that the density is normalized with the same backend used for the computation should not be on the user's shoulders. |
In #214 we see that its probably a bad idea to have same normalization across for different backends and methods.
This issue can be used to discuss on how we could have it in a single function which could be a wrapper over density function possibly, something like:
The question is that some normalizations need a
fourier_op
, which need not be required for estimation schemes likevoronoi
.It raises the question on which backend to use then?
I propose the following defaults:
voronoi
, we usefinufft
by default to keep compute on CPUpipe
use the backend same as which backend carried out the estimation.WDYT @paquiteau ?
The text was updated successfully, but these errors were encountered: