From b653af6e414d0b1a922d491b2a08608bb721b223 Mon Sep 17 00:00:00 2001 From: 13674301140 Date: Wed, 25 Dec 2024 02:41:20 +0800 Subject: [PATCH] refactor: fix code review comments --- .../bert_imdb_finetune_npu_mindnlp_trainer.sh | 1 - mindnlp/utils/download.py | 6 ++---- mindnlp/utils/winfcntlock.py | 9 +++------ 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/llm/parallel/bert_imdb_finetune_dp/bert_imdb_finetune_npu_mindnlp_trainer.sh b/llm/parallel/bert_imdb_finetune_dp/bert_imdb_finetune_npu_mindnlp_trainer.sh index d70445877..a9ceea756 100644 --- a/llm/parallel/bert_imdb_finetune_dp/bert_imdb_finetune_npu_mindnlp_trainer.sh +++ b/llm/parallel/bert_imdb_finetune_dp/bert_imdb_finetune_npu_mindnlp_trainer.sh @@ -20,7 +20,6 @@ echo "start training" export MULTI_NPU="true" export ASCEND_SLOG_PRINT_TO_STDOUT=1 -export ASCEND_RT_VISIBLE_DEVICES=6,7 # Specify the available card numbers msrun --worker_num=2 --local_worker_num=2 --master_port=8121 \ --log_dir=bert_imdb_finetune_cpu_mindnlp_trainer_npus_same --join=True \ diff --git a/mindnlp/utils/download.py b/mindnlp/utils/download.py index c3ad5be6f..299f8d201 100644 --- a/mindnlp/utils/download.py +++ b/mindnlp/utils/download.py @@ -147,11 +147,9 @@ def threads_exclusive_http_get(url, storage_folder=None, md5sum=None, download_f pointer_path = os.path.join(storage_folder, download_file_name) lock_file_path = pointer_path + ".lock" if sys.platform != "win32": -# pylint: disable=import-error - import fcntl + import fcntl # pylint: disable=import-error else: -# pylint: disable=import-error - import winfcntlock as fcntl + import winfcntlock as fcntl # pylint: disable=import-error with open(lock_file_path, 'w') as lock_file: fd = lock_file.fileno() try: diff --git a/mindnlp/utils/winfcntlock.py b/mindnlp/utils/winfcntlock.py index 2ebb5f7de..a3988e2c7 100644 --- a/mindnlp/utils/winfcntlock.py +++ b/mindnlp/utils/winfcntlock.py @@ -13,12 +13,9 @@ # limitations under the License. # ============================================================================ """fcntl replacement for Windows.""" -# pylint: disable=import-error -import win32con -# pylint: disable=import-error -import pywintypes -# pylint: disable=import-error -import win32file +import win32con # pylint: disable=import-error +import pywintypes # pylint: disable=import-error +import win32file # pylint: disable=import-error LOCK_EX = win32con.LOCKFILE_EXCLUSIVE_LOCK