Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs/enhancements #2

Open
dapperdrop opened this issue Jan 12, 2020 · 5 comments
Open

Bugs/enhancements #2

dapperdrop opened this issue Jan 12, 2020 · 5 comments
Labels
question Further information is requested

Comments

@dapperdrop
Copy link
Member

@kingo55 @allmywant

Lets collate bugs/enhancements here before chunking it down to separate issues to prioritise.

Here's what I've found in my initial usage of the extension:

Enhancements

  • Need a expand all toggle in the header bar

  • Colour palette for dark mode

  • Remove "N/A - " from "N/A - Trigger not activated" copy. I think "Trigger not activated" is descriptive enough.

  • Search space: Include experiment name in the search index

  • Search input field: add placeholder text "search by id or experiment name"

  • All font sizes can be reduced somewhat, e.g. refer to font size of the table in the Network tab

Bugs

  • For the "darker rows" the expanded state doesn't have the same bottom margin as the "lighter rows"
@dapperdrop dapperdrop added the question Further information is requested label Jan 12, 2020
@allmywant
Copy link
Member

@dapperdrop
All clear except this one:

For the "darker rows" the expanded state doesn't have the same bottom margin as the "lighter rows"

In fact they have the same bottom margin (15px), the reason it looks like different is: the lighter row next to a darker row has the white background color. I will find a way to let them have same looks.

@kingo55
Copy link
Member

kingo55 commented Jan 13, 2020

Enhancements:

  • Add some Snowplow tracking & Mojito (for running experiments - or at least tagging up behaviours we want to optimise for)
  • " Hide N/A" -> "Hide inactive"
  • UTM tagging on the Mojito link
  • Link Mojito logo to Mojito.mx + with UTM tagging
  • Names / IDs in the main column? Show on mouseover for clean look, but not hiding info behind a click?
  • Larger click target for expanding the info section
  • More info in the Chrome Menu popout than "Mojito is not running on this page" - shorter/responsive layout of the main panel, with fewer features? Links and logo pointing to the site?

@dapperdrop
Copy link
Member Author

Names / IDs in the main column? Show on mouseover for clean look, but not hiding info behind a click?

I think if we shrink font sizes a bit, we can include experiment name in it's own column. The only drawback is that sometimes we have the Wave number in the experiment name, which could look a bit awkward.

@kingo55
Copy link
Member

kingo55 commented Jan 13, 2020

Perhaps there's a better way we name tests - e.g. concatenate the ID and name in the storage adapter. Not sure of a good way to handle this though.

@dapperdrop
Copy link
Member Author

Maybe we can just de-emphasise the ID column. I think convert does this. Just a lighter font colour for the ID column. That way the focus will be on the experiment name, but ID still visually accessible.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants