Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current styling applied when pagination item is not current #653

Open
ricklambrechts opened this issue Sep 5, 2024 · 1 comment
Open
Labels
bug Something isn't working Pagination Component 'Pagination'

Comments

@ricklambrechts
Copy link
Member

We just had the issue that we where setting aria-current to false on a pagination list item and then the aria-current styling still applies.

Should this code be more like [aria-current]:not([aria-current="false"]) or [aria-current="true"]?

&[aria-current] {
@extend %pagination-active-item-styling;
}

@ppvg
Copy link
Member

ppvg commented Sep 5, 2024

For pagination [aria-current="page"] would make sense.

@ppvg ppvg added the bug Something isn't working label Sep 6, 2024
@HeleenSG HeleenSG added the Pagination Component 'Pagination' label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Pagination Component 'Pagination'
Projects
None yet
Development

No branches or pull requests

3 participants