You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When wrapping errors, we are passing the error property, which ERARO doesn't do anything with. As a result any of the errors coming from this library have 'unknown' in their message body.
I resolved this locally by removing all usage of the ERARO library and just calling the standard callbacks with any errors we receive. e.g:
if(err){returndone(err)}
This seems to work splendidly. The seneca code receiving the callback values already wraps them with ERARO, and it already logs errors if necessary. So we can cut out code like this too:
When wrapping errors, we are passing the
error
property, which ERARO doesn't do anything with. As a result any of the errors coming from this library have 'unknown' in their message body.I resolved this locally by removing all usage of the ERARO library and just calling the standard callbacks with any errors we receive. e.g:
This seems to work splendidly. The seneca code receiving the callback values already wraps them with ERARO, and it already logs errors if necessary. So we can cut out code like this too:
Does this seem right? I'll submit a pull request if so.
The text was updated successfully, but these errors were encountered: