Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default TTL #72

Closed
mircea-pavel-anton opened this issue Aug 13, 2024 · 7 comments
Closed

feat: Default TTL #72

mircea-pavel-anton opened this issue Aug 13, 2024 · 7 comments

Comments

@mircea-pavel-anton
Copy link
Collaborator

inject a default TTL on all records that don't have one specified via MIKROTIK_DEFAULT_TTL

@mircea-pavel-anton
Copy link
Collaborator Author

As observed during #14

Setting a default TTL also impacts the TXT record generated by external dns to track ownership of records. For some reason (i did not investigate this too much just yet), this prevents those records from being created thus preventing external dns to assume ownership of the created dns records.

Further investigation would be needed for this, but to be fully honest i am not sure if it is really worth the time and the headache to work around this. I would probably just set up something on the k8s side to have a more robust solution that achieves fundamentally the same thing (a mutating webhook maybe?).

@mircea-pavel-anton
Copy link
Collaborator Author

Leaving this here to see if it gains any traction and people would like such a feature added.

@mircea-pavel-anton
Copy link
Collaborator Author

https://github.com/kubernetes-sigs/external-dns/blob/master/provider%2Faws%2Faws.go#L511-L544

This may be relevant? A similar function comparing expected and current state, keeping track of default values.

@nobleess
Copy link
Contributor

hi, I need this feat
my solution #173

@tajinder400
Copy link

Interestingly enough, I'm interested in getting this added too. I've noticed when a value of 0 TTL is given to a record, I'm unable to resolve the static DNS names on both Windows and Linux machines. Creating records in the same fashion, or amending them, but adding a value greater than 0 is enough for it to be resolvable by any machine I have.

Do you have this same issue @nobleess ? I'm curious as to your interest in this feature request also?

@nobleess
Copy link
Contributor

I encountered the same issue on Linux machines @tajinder400

@mircea-pavel-anton
Copy link
Collaborator Author

Fixed in #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants