Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widget rectangle works draws area too small #1676

Open
Stefku opened this issue Jan 5, 2023 · 2 comments
Open

widget rectangle works draws area too small #1676

Stefku opened this issue Jan 5, 2023 · 2 comments

Comments

@Stefku
Copy link
Contributor

Stefku commented Jan 5, 2023

I've got the config

displays:
  window:
    width: 1280
    height: 720
window:
  width: 1280
  height: 720
  title: Mission Pinball Framework
  resizable: false
  fullscreen: false
  borderless: false
  exit_on_escape: true
  source_display: window

With the following widget, there appears just an rectangle quarter of the window. Other widgets use the whole window.

    - type: rectangle
      x: 0
      y: 0
      width: 1280
      height: 720
      color: pink

Screenshot 2023-01-05 at 19 20 12

@atummons
Copy link
Contributor

This appears to be bad documentation here. Widgets claim they anchor from the bottom left corner. Thus it should fill the whole thing. However, rectangles actually are anchoring from the middle. So when you say X: 0 and y: 0, you are putting the middle in the bottom corner. The whole thing is there, just only the top right quadrant is shown.

Changing this would be breaking for others, so updating docs is the best approach.

If you remove x and y, it with default center. Additionally if you add anchor_x: left and anchor_y: bottom then it will appear as expected.

From cmd use mpf imc to see an interactive MC. This allows you to play with positioning, then copy it into your config.

@atummons
Copy link
Contributor

I'll amend that slightly.

https://missionpinball.org/mc/widgets/common_settings/

The default anchor position is middle. This is inconsistent with what shows elsewhere. So this page matches how the code works. Other pages are inconsistent though. I'll try to run through and fix them and the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants