Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of Internal/External Links #1148

Open
Jan-Eimertenbrink opened this issue Jan 31, 2025 · 0 comments
Open

Clarification of Internal/External Links #1148

Jan-Eimertenbrink opened this issue Jan 31, 2025 · 0 comments
Labels
documentation Improvements or additions to documentation feedback

Comments

@Jan-Eimertenbrink
Copy link
Member

Jan-Eimertenbrink commented Jan 31, 2025

In the style guide, we define links under Internal and External Links as follows:

Interne Links öffnen sich immer im dem Tab, in dem der User sich gerade befindet. Der User kann jedoch selbst entscheiden, ob er den Link lieber in einem neuen Tab öffnen möchte. Externe Links öffnen sich immer in einem neuen Tab. Um das Verhalten dem User zu verdeutlichen, muss neben dem Text das Icon IconExternalLink angezeigt werden.

This raises the question: What exactly is an internal, and what is an external link?
Does an internal link apply to everything within the mittwald ecosystem, for example? Would a link from the Styleguide to mittwald.de be considered internal? Or does internal only refer to content on the same domain?
To avoid confusion, this distinction should be explicitly added to the section on handling internal and external links.

Addition

In the last part of the section: It’s about paying attention to the icon. However, the icon appears automatically as soon as target="_blank" is set.

@Jan-Eimertenbrink Jan-Eimertenbrink added documentation Improvements or additions to documentation feedback labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feedback
Projects
None yet
Development

No branches or pull requests

1 participant