Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong index type #24

Open
Katterrina opened this issue Nov 26, 2024 · 2 comments
Open

Wrong index type #24

Katterrina opened this issue Nov 26, 2024 · 2 comments
Labels
question Further information is requested

Comments

@Katterrina
Copy link

Hi,

I think there should be faiss.IndexFlatIP instead of faiss.IndexFlatL2 in the aggregation script.

Katerina

@heathcliff233 heathcliff233 added the question Further information is requested label Nov 27, 2024
@heathcliff233
Copy link
Collaborator

Dear Katerina,

Thank you for reading our paper into detail and the question. We have updated our model to v2 to support esm2 and have changed to L2 distance in order to support more optimization methods in faiss package. I will add some explanations to avoid ambiguity.

Best,
Liang

@Katterrina
Copy link
Author

Katterrina commented Nov 27, 2024

Thank you very much for the quick reply! I have a follow up question: If I download model checkpoints using the link from README (link to the checkpoint), am I supposed to use L2 distance or IP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants