Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAM improvements #277

Open
24THEGuNNeR07 opened this issue Nov 26, 2024 · 2 comments
Open

RAM improvements #277

24THEGuNNeR07 opened this issue Nov 26, 2024 · 2 comments

Comments

@24THEGuNNeR07
Copy link

24THEGuNNeR07 commented Nov 26, 2024

Hi !
Just had a look on memory consumption after loading dataset. After 3D texture creation I believe we can clean RAM from pixel data namely VolumeDataset.data and some arrays in importer classes. Can be useful especially when loading multiple datasets.
What do you think ?
Regards

@mlavik1
Copy link
Owner

mlavik1 commented Nov 28, 2024

Hi @24THEGuNNeR07,
Thanks for reaching out!
That's a great point! We already remove the texture data from memory (by calling Texture3D.Apply with makeNoLongerReadable set to true, however the VolumeDataset.data is still in memory.
For some uses it is necessary to keep this array in memory, since they may query or modify it, however maybe we could add a setting for automatically clearing it when it's no longer needed? Or alternatively a method for clearing it, and then adding some checks to make sure we don't get errors when we try to access it after it has been cleared.

@24THEGuNNeR07
Copy link
Author

Hmm not sure what's the case when you need this data in memory can you give some examples ? I would say if it's rare then import them again from file if that would be not suitable because of too often waiting process then I'd leave it as it is and clear it only on importer scripts side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants