Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getter functions for ETFeeder #176

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

JoongunPark
Copy link
Contributor

@JoongunPark JoongunPark commented Jan 5, 2025

Summary

This PR updates ETFeeder to have getter functions of I/O attributes.
The I/O attributes include value/shape/type for the node.

Node that this feature is also required in other code in Feeder ( json_node.cpp json_node.h wrapper_node.cpp wrapper_node.h) which can be done after we decide details of JSON format.

Test Plan

This is tested with ASTRA-Sim as shown in below.

void Workload::initialize_process_group(std::shared_ptr<Chakra::ETFeederNode> node) {
    std::string pg_info = node->get_inputs_values();
    if (pg_info.empty()) {
        std::cerr << "Process Group Information is not encoded" << std::endl;
        return;
    }
    ....
}

@JoongunPark JoongunPark requested a review from a team as a code owner January 5, 2025 19:49
Copy link

github-actions bot commented Jan 5, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@tushar-krishna
Copy link
Contributor

Looks good!

@tushar-krishna tushar-krishna merged commit 3309b1d into mlcommons:main Jan 30, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants