Add GNN training benchmark #359
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
| CHECK: " v['value'] > 0" | ||
|
|
||
| - KEY: | ||
| NAME: opt_name |
There was a problem hiding this comment.
In the reference code, the optimizer name is not reported, but we do have a SEED exported at this line. Should we report the optimizer name as well in the reference code? And should we also check if the seed is included in the log as well?
There was a problem hiding this comment.
We should report optimizer name in reference. The seed check is part of package_checker and we don't need to include it here.
| POST: " enqueue_config('training_4.0.0/closed_{}.yaml'.format(v['value'])) " | ||
|
|
||
| - KEY: | ||
| NAME: gradient_accumulation_steps |
There was a problem hiding this comment.
We actually do not have this key in the reference implementation (mllog.constants.GRADIENT_ACCUMULATION_STEPS). Should we also include this in the reference branch? Or is it okay for us to directly remove this in the closed_common.yaml checker?
There was a problem hiding this comment.
Let's include gradient acccumulation in reference, as we should not be modifying the common yaml.
There was a problem hiding this comment.
Gradient accumulation is included in reference.
|
LGTM |
|
@drcanchi please resolve the conflicts so that we can merge. Thanks! |
No description provided.