Fix build and linting #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to fix the build first for dynamic linking with Homebrew... |
edg-l
approved these changes
Jan 7, 2025
raviqqe
added a commit
that referenced
this pull request
Jan 7, 2025
This PR changes the `add_source_file` method in Rust to use `AddIncludeFile` in C++ which resolves given file paths from include directories. This PR depends on #19. # References - mlir-rs/melior#654 - https://llvm.org/doxygen/classllvm_1_1SourceMgr.html
Merged
raviqqe
added a commit
to raviqqe/tblgen-rs-alt
that referenced
this pull request
Jan 8, 2025
This PR fixes build for Linux + Homebrew environment and lining for the new version of Rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes build for Linux + Homebrew environment and lining for the new version of Rust.