update min version of dataclass-wizard to v0.29.2 #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update minimum version of
dataclass-wizard
to0.29.2
which fixed bug which meant it wasn't possible to defineUnion
types while checking that all keys in the loaded yaml-config file matched a field in the config dataclass (rnag/dataclass-wizard#137). The pressense of this bug meant inneural-lam
that we had to keepraise_on_unknown_json_key
to its defaultFalse
value. We should ensure that people have a version ofdataclass-wizard
installed that means we can check the config yaml against the config dataclass while supporting union types.I have run the tests both against
0.29.2
and also0.35.0
(whichdataclass-wizard>=0.29.2
currently resolves to) ofdataclass-wizard
.Issue Link
Closes #43
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee