Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NetworkedDOM element syncing (#176) #180

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

MarcusLongmuir
Copy link
Collaborator

Fixes #176.

This PR addresses a class of issues where if multiple mutations occurred in a single tick (e.g. append an element to multiple parents one after the other) they could cause errors in the ObservableDOM handling because the inferred state from a single mutation would conflict with the handling of a subsequent mutation.

This is a complication that is tracked in #100.

This PR also adds tests to avoid regressions on this behaviour and integration tests that assert the state of the client NetworkedDOMWebsocket match the state of the server document NetworkedDOMDocument


What kind of changes does your PR introduce? (check at least one)

  • Bugfix

Does your PR introduce a breaking change? (check one)

  • No

Does your PR fulfill the following requirements?

  • All tests are passing
  • The title references the corresponding issue # (if relevant)

@TheCodeTherapy TheCodeTherapy merged commit ea9553d into main Jun 19, 2024
8 checks passed
@TheCodeTherapy TheCodeTherapy deleted the bugfix/duplicate-nodes branch June 19, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error: Virtual element not found for real element
2 participants