Fix NetworkedDOM element syncing (#176) #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176.
This PR addresses a class of issues where if multiple mutations occurred in a single tick (e.g. append an element to multiple parents one after the other) they could cause errors in the
ObservableDOM
handling because the inferred state from a single mutation would conflict with the handling of a subsequent mutation.This is a complication that is tracked in #100.
This PR also adds tests to avoid regressions on this behaviour and integration tests that assert the state of the client
NetworkedDOMWebsocket
match the state of the server documentNetworkedDOMDocument
What kind of changes does your PR introduce? (check at least one)
Does your PR introduce a breaking change? (check one)
Does your PR fulfill the following requirements?