Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow algorithms that only need acc to work without gyr provided #172

Open
AKuederle opened this issue Jul 11, 2024 · 0 comments
Open

Allow algorithms that only need acc to work without gyr provided #172

AKuederle opened this issue Jul 11, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AKuederle
Copy link
Contributor

With the recent change to body frame data everywhere, we check that all columns of the expected frame (which includes acc and gyr) are available in the data, even if they are not used later in the algorithm.

To make the algorithms that don't need gyro usable again for data without gyro, we might want to be more granular in our checks.

However, this requires multiple steps:

  1. The dtype check func need an option to configure which sensors you assume to be there
  2. The to_body_frame/to_sensor_frame funcs need to work, when either acc or gyr is missing.
  3. All algorithms need to be updated to use the correct sensor axis and call the dtype check funcs correctly, depending on their needs
@AKuederle AKuederle added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant