Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no recbuf on socket #153

Closed
jgrnt opened this issue Mar 5, 2015 · 1 comment · Fixed by #154
Closed

Allow no recbuf on socket #153

jgrnt opened this issue Mar 5, 2015 · 1 comment · Fixed by #154

Comments

@jgrnt
Copy link
Contributor

jgrnt commented Mar 5, 2015

Hi,

I would to integrate the idea initially proposed in #134, where also no recbuf option can be supplied to the gen_tcp socket.
I was investigating discoproject/disco#603 under Linux and figured out that when an explicit RCVBUF is set on the socket under linux, this limits the maximum TCP window, which leads on a high latency link (200ms RTT) to very poor performance (few kb/s)
(Details about the window sizing in linux can be found in http://www.psc.edu/index.php/networking/641-tcp-tune#Linux)

So when i removed recbuf I got comparable performance to a low-latency link.
In order do not break backwards compatibility I propose as in #134 to set the recbuf option to undefined to override the default.

@etrepum
Copy link
Member

etrepum commented Mar 5, 2015

Sounds reasonable, go ahead and send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants