Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSL 4.1.0 Reference results for new models #4349

Closed
maltelenz opened this issue Feb 29, 2024 · 15 comments
Closed

MSL 4.1.0 Reference results for new models #4349

maltelenz opened this issue Feb 29, 2024 · 15 comments
Assignees
@casella @AHaumer
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined L: Resources Issue addresses Modelica/Resources (excl. C-Sources) P: high High priority issue ref-result Issue addresses the reference results
Milestone
MSL4.1.0

Comments

@maltelenz
Copy link
Contributor

maltelenz commented Feb 29, 2024 •
edited by casella
Loading

MSL 4.1.0 comes with new example models compared to 4.0.0.

These need new reference results at https://github.com/modelica/MAP-LIB_ReferenceResults/tree/v4.1.0

List of new models:

Modelica.Blocks.Examples.DemonstrateContinuousSignalExtrema
Modelica.Blocks.Examples.DemonstrateSignalExtrema
Modelica.Blocks.Examples.DemoSignalCharacteristic
Modelica.Electrical.Analog.Examples.DemonstrateLightning
Modelica.Electrical.Analog.Examples.DemoPowerSupply
Modelica.Electrical.Analog.Examples.DemoPowerSupplyWithBuffer
Modelica.Electrical.Analog.Examples.Lines.CompareLineTrunks
Modelica.Electrical.Analog.Examples.Lines.CompareLosslessLines
Modelica.Electrical.Analog.Examples.Lines.LightningLosslessTransmissionLine
Modelica.Electrical.Analog.Examples.Lines.LightningSegmentedTransmissionLine
Modelica.Electrical.Analog.Examples.Lines.SmoothStep
Modelica.Electrical.Machines.Examples.DCMachines.DCPM_Drive
Modelica.Electrical.PowerConverters.Examples.DCDC.ChopperBuckBoost.ChopperBuckBoost_DutyCycle
Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
Modelica.Electrical.QuasiStatic.SinglePhase.Examples.MultipleResonance
Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.ComparisonPolyphase.IMC_DOL_CommonLeakage
Modelica.Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Inverter
Modelica.Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.SynchronousMachines.SMPM_FieldWeakening
Modelica.Mechanics.Rotational.Examples.CompareBrakingTorque
Modelica.Mechanics.Translational.Examples.CompareBrakingForce
ModelicaTest.Blocks.Exponentiation
ModelicaTest.Blocks.ZeroThresholds
ModelicaTest.Electrical.Machines.DCPM_CurrentControlled
ModelicaTest.Electrical.Machines.DCPM_SpeedControlled
ModelicaTest.Electrical.SingularTransformer
ModelicaTest.Fluid.TestComponents.Machines.TestLinearPower
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck2
ModelicaTest.MultiBody.Frames.QuaternionFromT
ModelicaTest.Tables.CombiTable1Ds.Test35
ModelicaTest.Tables.CombiTable1Dv.Test35
ModelicaTest.Tables.CombiTable2Ds.OneSidedDerivative2D
ModelicaTest.Tables.CombiTable2Ds.Test32
ModelicaTest.Tables.CombiTable2Ds.Test33
ModelicaTest.Tables.CombiTable2Dv.OneSidedDerivative2D
ModelicaTest.Tables.CombiTable2Dv.Test32
ModelicaTest.Tables.CombiTable2Dv.Test33
ModelicaTest.Tables.CombiTimeTable.Test89
@maltelenz maltelenz added the ref-result Issue addresses the reference results label Feb 29, 2024
@maltelenz maltelenz added this to the MSL4.1.0 milestone Feb 29, 2024
@beutlich
Copy link
Member

beutlich commented Feb 29, 2024 •
edited
Loading

Sure. Already available at https://github.com/beutlich/MAP-LIB_ReferenceResults for patched v4.1.0-beta.1.

@beutlich beutlich mentioned this issue Mar 21, 2024
Closed
@beutlich
Copy link
Member

Sure. Already available at for patched v4.1.0-beta.1.

After spending some more time on #4343 I only noticed now that some of the simulation result is no longer reproducable. Not sure what I did then (beside the too much manual patching). In order not to use it I removed that fork for now. Sorry for the inconvenience.

@maltelenz
Copy link
Contributor Author

These models are missing a corresponding comparisonSignals.txt:

Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck2

@beutlich
Copy link
Member

beutlich commented May 15, 2024 •
edited
Loading

These models are missing a corresponding comparisonSignals.txt:

Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck2

Confirmed, see #3679 for the first and #3959 for the other two. I actually wonder why I missed them for #4304. (Edit: Fixed by modelica-tools/msl-release@71b4d6a)

@AHaumer @casella This needs to be fixed before tagging a new release.

@beutlich beutlich added L: Resources Issue addresses Modelica/Resources (excl. C-Sources) L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined P: high High priority issue labels May 15, 2024
@casella casella mentioned this issue Jun 18, 2024
Merged
@casella
Copy link
Contributor

casella commented Jun 18, 2024 •
edited
Loading

For the HBridge_TrianglePWM_RL results, I opened PR #4423 for @AHaumer to check.

Once accepted, it need to be back-ported to maint/4.1.0 before closing this ticket.

@casella casella mentioned this issue Jun 18, 2024
Merged
@casella
Copy link
Contributor

casella commented Jun 18, 2024

For the two new dynamic pipe check models, I opened PR #4425.

Once accepted, it need to be back-ported to maint/4.1.0 before closing this ticket.

@Esther-Devakirubai
Copy link
Contributor

Backported #4425 to maintenance by #4450

@casella
Copy link
Contributor

casella commented Aug 16, 2024

@Esther-Devakirubai can you also please backport #4423, adding the same reviewers as the original PR? Thanks!

@Esther-Devakirubai
Copy link
Contributor

@Esther-Devakirubai can you also please backport #4423, adding the same reviewers as the original PR? Thanks!

Done by #4454 . Thanks

@maltelenz maltelenz mentioned this issue Jan 27, 2025
Open
@casella
Copy link
Contributor

casella commented Feb 24, 2025 •
edited
Loading

@maltelenz, I'm trying to understand if we can close this issue. In your first post, you listed

  • 20 new models in Modelica
  • 18 new models in ModelicaTest

However, there are only

  • 19 new reference file results for Modelica in LTX's report (one less)
  • 16 new reference file results for ModelicaTest in LTX's report (two less)

The three missing new results in LTX's new model reports that were present in @maltelenz's first post are:

  • Modelica.Blocks.Examples.DemonstrateSignalExtrema
  • ModelicaTest.Blocks.Exponentiation
  • ModelicaTest.Electrical.SingularTransformer

It turns out:

  • ModelicaTest.Blocks.Exponentiation is missing (not in testrun) from the current ModelicaTest report
  • ModelicaTest.Electrical.SingularTransformer is already present in the current ModelicaTest report
  • Modelica.Blocks.Examples.DemonstrateSignalExtrema is already present in the current Modelica report

@GallLeo, @MatthiasBSchaefer

  • were ModelicaTest.Electrical.SingularTransformer and Modelica.Blocks.Examples.DemonstrateSignalExtrema added to the repo in the past and already approved by library officers?
  • why is ModelicaTest.Blocks.Exponentiation still missing from the ModelicaTest 4.1.0 reference result repo, as well as from your list of new results for library officers' approval?

@MatthiasBSchaefer
Copy link
Contributor

ModelicaTest.Blocks.Exponentiation and Modelica.Blocks.Examples.DemonstrateSignalExtrema:
I'am sorry: Due to a little error in the input of our comparison tool, the first example in Modelica and ModelicaTest was missing to be compared in
https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/Modelica_NewExamples/testrun_report.html
and
https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/ModelicaTest_NewExamples/testrun_report.html

This is fixed now.

ModelicaTest.Electrical.SingularTransformer:
This is just the correction of a typo. In MSL 4.0.0 the example was named SingularTransfomer (without "r")
I don't think a review of a library-officer is necessary in this case.

Since the procedure wasn't clear at this time, Leo and me created and pushed already reference files for the new Modelica examples (not ModelicaTest)
in modelica/MAP-LIB_ReferenceResults@8afbe24 ff. several weeks ago.
This was an attempt to make the comparison results of the new examples visible on our regression server for the library officers.
Unfortunately this attempt failed, because - due to limited space of the server - we can only show failed comparisons there (which is not the case for any of the new example models).
So we agreed on the current procedure to compare the new examples with tightend- and normal tolerance (from experiment annotation), which are shown on https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/Modelica_NewExamples/testrun_report.html.
If there will be an issue after the review of the library officers, we can re-update the corresponding reference files.

@maltelenz
Copy link
Contributor Author

@casella I think we can close this once library officers have reviewed the new results and modelica/MAP-LIB_ReferenceResults#17 is merged.

@AHaumer
Copy link
Contributor

AHaumer commented Feb 25, 2025

My answer was given by email:
I checked the following and they look reasonable to me:
Blocks.Examples.DemonstrateContinuousSignalExtrema
Blocks.Examples.DemoSignalCharacteristic
Electrical.Analog.Examples.DemonstrateLightning
Electrical.Analog.Examples.DemoPowerSupply
Electrical.Analog.Examples.DemoPowerSupplyWithBuffer
Electrical.Analog.Examples.Lines.CompareLosslessLinesElectrical.Analog.Examples.Lines.SmoothStep
Electrical.Analog.Examples.Lines.CompareLineTrunks
Electrical.Analog.Examples.Lines.LightningLosslessTransmissionLine
Electrical.Analog.Examples.Lines.LightningSegmentedTransmissionLine
Electrical.Machines.Examples.DCMachines.DCPM_Drive
Electrical.PowerConverters.Examples.DCDC.ChopperBuckBoost.ChopperBuckBoost_DutyCycle
Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
Electrical.QuasiStatic.SinglePhase.Examples.MultipleResonance
Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.ComparisonPolyphase.IMC_DOL_CommonLeakage
Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Inverter
Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.SynchronousMachines.SMPM_FieldWeakening
Mechanics.Rotational.Examples.CompareBrakingTorque
Mechanics.Translational.Examples.CompareBrakingTorque
ModelicaTest.Blocks.ZeroThresholds
ModelicaTest.Electrical.Machines.DCPM_CurrentControlled
ModelicaTest.Electrical.Machines.DCPM_SpeedControlled

@casella
Copy link
Contributor

casella commented Feb 27, 2025

@maltelenz based on @MatthiasBSchaefer, all the new reference files in this commit (as well as some that were already committed earlier to the 4.1.0 branch) have been reviewed by the relevant library officers. We can go ahead with the merging.

@casella
Copy link
Contributor

casella commented Feb 27, 2025

modelica/MAP-LIB_ReferenceResults#17 is now closed.

@casella casella closed this as completed Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casella casella

@AHaumer AHaumer

Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined L: Resources Issue addresses Modelica/Resources (excl. C-Sources) P: high High priority issue ref-result Issue addresses the reference results
Projects
None yet
Milestone
MSL4.1.0
Development

No branches or pull requests
6 participants
@maltelenz @casella @AHaumer @beutlich @MatthiasBSchaefer @Esther-Devakirubai