Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong unit definition in ModelicaTest.Media.TestOnly.R134a_setState_phX #4550

Open
MatthiasBSchaefer opened this issue Feb 26, 2025 · 1 comment · May be fixed by #4551
Open

wrong unit definition in ModelicaTest.Media.TestOnly.R134a_setState_phX #4550

MatthiasBSchaefer opened this issue Feb 26, 2025 · 1 comment · May be fixed by #4551

Comments

@MatthiasBSchaefer
Copy link
Contributor

The new example ModelicaTest.Media.TestOnly.R134a_setState_phX from
0f769ac
contains the line
SI.Temperature h = Medium.h_default;
This is a mix up of the quantities Temperature and specific Enthalpy...
@MatthiasBSchaefer MatthiasBSchaefer changed the title wrong Unit definition in ModelicaTest.Media.TestOnly.R134a_setState_phX wrong unit definition in ModelicaTest.Media.TestOnly.R134a_setState_phX Feb 26, 2025
@MatthiasBSchaefer MatthiasBSchaefer mentioned this issue Feb 26, 2025
Draft
@HansOlsson
Copy link
Contributor

There are actually two related errors:

     SI.Temperature h = Medium.h_default; 
...
      SI.SpecificEnthalpy T= Medium.temperature(state);

They should be swapped.

HansOlsson added a commit to HansOlsson/Modelica that referenced this issue Feb 26, 2025
@HansOlsson
Swap units to correct place.
452efdf 
Closes modelica#4550
@HansOlsson HansOlsson linked a pull request Feb 26, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swap units to correct place. HansOlsson/Modelica
2 participants
@HansOlsson @MatthiasBSchaefer