Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bootstrap 5 #128

Open
kraih opened this issue Mar 19, 2024 · 4 comments
Open

Update to Bootstrap 5 #128

kraih opened this issue Mar 19, 2024 · 4 comments

Comments

@kraih
Copy link
Member

kraih commented Mar 19, 2024

Similar to mojolicious/mojo#1975, we need to update the Minion admin UI from Bootstrap 4 to 5.

@rshingleton
Copy link

I was considering cloning the admin plugin for an internal application that I support to eliminate the long polling and add WebSocket functionality for the live updates as well as improving the UI. I may be able to backport some of this into the AdminUI. I'll create a pull request when I get far enough along and I think it's worthwhile.

@rshingleton
Copy link

Some questions. I started looking at this this evening and I think the update to BS 5 won't be a huge effort. I would like to see some additional functionality on the tables for sorting and searching primarily. We use Datatables in most of our monitoring stack, but I would have to add some more dependencies and rework the jobs.html.ep quite a bit.

In our internal app I have a few custom Minion interfaces using this:

image

and a json view for extended job data.
image

I've also implemented websockets to do the UI updates instead of the current long polling.

So my questions are:

  • Do you just want a 1 to 1 update with the existing UI to BS 5
  • Do you like additional functionality (datatables, websockets, etc)
  • Do you want updates to other packages in the UI, I thought I saw something on epoch.js somewhere as well

I'm sure I have more questions, but I didn't want to start tearing things down too much without asking.

@rabbiveesh
Copy link

I would be happy to help maintain a more feature filled frontend; it would save me a lot of time bc I need to build a fuller dashboard for $work.

Though you can always just publish your own admin UI as a separate plugin

@kraih
Copy link
Member Author

kraih commented Jun 3, 2024

Please don't add functionality in this ticket, it is only about the Bootstrap 5 conversion. Any changes or additions would probably result in a rejection of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants