Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification generation not ported to new API #760

Open
tsa96 opened this issue Jun 23, 2023 · 1 comment
Open

Notification generation not ported to new API #760

tsa96 opened this issue Jun 23, 2023 · 1 comment
Labels
For: Backend This is something to do for the backend (server folder) of the website. Priority: High Should be done first and foremost, absolutely essential for this release. Size: Medium Something that may take a few days or so to implement. Type: Enhancement Something that builds on top of what already exists

Comments

@tsa96
Copy link
Member

tsa96 commented Jun 23, 2023

Something I just realized we forgot to port. On the old API, whenever activities are created, the genNotification function is run that generates notifications for users with MapNotifys and Follows. models/activity.js.

We should

  • Create a dedication createActivity method in ActivityService
  • Port all the logic from old API to there/private methods in ActivityService
  • Find all calls to UsersRepoService.createActivities and replace with calls to above method
@tsa96 tsa96 added Type: Enhancement Something that builds on top of what already exists Priority: High Should be done first and foremost, absolutely essential for this release. Size: Medium Something that may take a few days or so to implement. For: Backend This is something to do for the backend (server folder) of the website. labels Jun 23, 2023
@tsa96 tsa96 mentioned this issue Jun 23, 2023
Open
@tsa96
Copy link
Member Author

tsa96 commented Jun 23, 2023 •
edited
Loading

Can do #196 during this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
For: Backend This is something to do for the backend (server folder) of the website. Priority: High Should be done first and foremost, absolutely essential for this release. Size: Medium Something that may take a few days or so to implement. Type: Enhancement Something that builds on top of what already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsa96