Improving performance of asking for collection names

mongoid · Jun 21, 2012 · 0f3cc46 · 0f3cc46
1 parent e5b290f
commit 0f3cc46
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/lib/moped/database.rb b/lib/moped/database.rb
@@ -114,11 +114,11 @@ def collections
     #
     # @since 1.0.0
     def collection_names
-      Collection.new(self, "system.namespaces").
-        find(name: { "$not" => /system|\$/ }).
-        map do |doc|
-          doc["name"].sub(/^#{name}./, '')
-        end
+      namespaces = Collection.new(self, "system.namespaces").find(name: { "$not" => /system|\$/ })
+      namespaces.map do |doc|
+        _name = doc["name"]
+        _name[name.length + 1, _name.length]
+      end
     end
   end
 end
diff --git a/perf/cases.rb b/perf/cases.rb
@@ -79,3 +79,9 @@
     end
   end.each &:join
 end
+
+profile "Ask for all collection names, 1000x" do
+  1_000.times do
+    session.collection_names
+  end
+end