New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent redundant notifications from /serialosc/notify #66

Open

tehn opened this issue Mar 30, 2023 · 0 comments

Member

tehn commented Mar 30, 2023

presently there are some situations where serialoscd can accumulate the same host/port many times in its notification queue

run serialosc client application, which sends /notify, gets on queue
quit
run same application, which sends /notify again
plug device, two /add messages will show up

fix would be to check the queue for existing host/port match before adding it again:

https://github.com/monome/serialosc/blob/main/src/serialoscd/uv.c#L389

the VECTOR module does not seem to have a PEEK function, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment