You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Following on from #765, there are still further optimisations possible to bring down the run time of the theme's behat suite.
Given the timing file and the work done on the previous bug, I have the following suggestions for further improvements, targeting the files currently taking >1000 seconds to run, as these will have the most impact:
The first 3 scenarios have been modified to use generators and the new named selectors for assertions. The rest of the scenarios can be converted too.
Some tests may not require Javascript. For example "Presentation - Display the menu item title in different types" can probably just check for the existstence of the title inside each menu.
"Presentation - Display the menu items title with icon" It might be possible to use named selectors rather than complex CSS selectors.
"Presentation - Add a smart menu item with multilang tags", "Presentation - Hide empty menus" As in Behat test optimisations #765, these assertions can be sped up with named selectors.
"Presentation - Image alt text for the dynamic menu items", "Presentation - Image alt text for the static menu items" Named selectors to replace long xpaths would make this more readable.
Is it actually necessary for every scenario to check the popover opens correctly? If one can do that and the others just check the links exist in the correct container, they could run without Javascript.
As above, the same optimisations as the menuitems feature a probably possible, and it may be further possbile to combine these features to reduce redundancy.
theme_boost_union_contentsettings_slider.feature
The background uploads a file to a filepicker for each scenario, although not all scenarios assert it exists. If this is not necessary, it could be included in just the scenarios where it is.
If it is necessary, this and other uploaded files could benefit from a generator which simulates saving the files in backend code, rather than uploading them throught he UI.
The text was updated successfully, but these errors were encountered:
marxjohnson
added
the
new
Something which has been reported but has not yet beeen triaged by the team
label
Feb 20, 2025
Describe the bug
Following on from #765, there are still further optimisations possible to bring down the run time of the theme's behat suite.
Given the timing file and the work done on the previous bug, I have the following suggestions for further improvements, targeting the files currently taking >1000 seconds to run, as these will have the most impact:
theme_boost_union_smartmenusettings_menuitems_presentation.feature
theme_boost_union_smartmenusettings_menus_rules.feature
theme_boost_union_smartmenusettings_menuitems_rules.feature
.theme_boost_union_contentsettings_staticpages.feature
theme_boost_union_smartmenusettings_menus_presentation.feature
menuitems
feature a probably possible, and it may be further possbile to combine these features to reduce redundancy.theme_boost_union_contentsettings_slider.feature
The text was updated successfully, but these errors were encountered: