From 3f34ec769b7a625fcc0f84ccab1305e7eb9df4ff Mon Sep 17 00:00:00 2001 From: Nima HeydariNasab Date: Sun, 19 Jan 2025 19:22:52 +0330 Subject: [PATCH] [fix] make nullable parameter type hint explicitly nullable --- README.md | 8 ++++---- src/Jalalian.php | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 363e5d0..22cde6a 100644 --- a/README.md +++ b/README.md @@ -63,7 +63,7 @@ $date = Jalalian::forge('now - 10 minutes')->ago() // 10 دقیقه پیش ```php -public static function now(\DateTimeZone $timeZone = null): Jalalian +public static function now(?\DateTimeZone $timeZone = null): Jalalian $jDate = Jalalian::now(); ``` @@ -77,7 +77,7 @@ $jDate = Jalalian::fromCarbon(Carbon::now()); --- ```php -public static function fromFormat(string $format, string $timestamp, \DateTimeZone$timeZone = null): Jalalian +public static function fromFormat(string $format, string $timestamp, ?\DateTimeZone$timeZone = null): Jalalian $jDate = Jalalian::fromFormat('Y-m-d H:i:s', '1397-01-18 12:00:40'); ``` @@ -85,14 +85,14 @@ $jDate = Jalalian::fromFormat('Y-m-d H:i:s', '1397-01-18 12:00:40'); --- ```php -public static function forge($timestamp, \DateTimeZone $timeZone = null): Jalalian +public static function forge($timestamp, ?\DateTimeZone $timeZone = null): Jalalian // Alias fo fromDatetime ``` --- ```php -public static function fromDateTime($dateTime, \DateTimeZone $timeZone = null): Jalalian +public static function fromDateTime($dateTime, ?\DateTimeZone $timeZone = null): Jalalian $jDate = Jalalian::fromDateTime(Carbon::now()) // OR diff --git a/src/Jalalian.php b/src/Jalalian.php index e859a63..4b99ebf 100644 --- a/src/Jalalian.php +++ b/src/Jalalian.php @@ -78,7 +78,7 @@ public function __construct( $this->timezone = $timezone; } - public static function now(\DateTimeZone $timeZone = null): Jalalian + public static function now(?\DateTimeZone $timeZone = null): Jalalian { return static::fromCarbon(Carbon::now($timeZone)); } @@ -102,12 +102,12 @@ public static function fromCarbon(Carbon $carbon): Jalalian ); } - public static function fromFormat(string $format, string $timestamp, \DateTimeZone $timeZone = null): Jalalian + public static function fromFormat(string $format, string $timestamp, ?\DateTimeZone $timeZone = null): Jalalian { return static::fromCarbon(CalendarUtils::createCarbonFromFormat($format, $timestamp, $timeZone)); } - public static function forge($timestamp, \DateTimeZone $timeZone = null): Jalalian + public static function forge($timestamp, ?\DateTimeZone $timeZone = null): Jalalian { return static::fromDateTime($timestamp, $timeZone); } @@ -117,7 +117,7 @@ public static function forge($timestamp, \DateTimeZone $timeZone = null): Jalali * @param \DateTimeZone|null $timeZone * @return Jalalian */ - public static function fromDateTime($dateTime, \DateTimeZone $timeZone = null): Jalalian + public static function fromDateTime($dateTime, ?\DateTimeZone $timeZone = null): Jalalian { if (is_numeric($dateTime)) { return static::fromCarbon(Carbon::createFromTimestamp($dateTime, $timeZone));