Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metric name handling more flexible and transparent #1722

Open
gsganden opened this issue Feb 12, 2025 · 0 comments
Open

Make metric name handling more flexible and transparent #1722

gsganden opened this issue Feb 12, 2025 · 0 comments

Comments

@gsganden
Copy link

I spent a lot of time trying to get a custom metric working only to realize that it wasn't showing up in the output simply because https://github.com/LocalResearchGroup/llm-foundry/blob/a4bd9fc08f8dac482970d42a94ef2cdda2659a60/llmfoundry/command_utils/eval.py#L473-L474 looks for "Accuracy" in the metric name. Would it be possible to (1) develop a more robust way to recognize metrics, (2) treat everything in logger_keys as a metric and record its name and value rather than assuming it is an "accuracy", or at least (3) make it more obvious why a metric without "Accuracy" in its name isn't showing up in the output?

I would be interested in developing a solution if we can align on the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant