Skip to content

Commit

Permalink
refactor: drop unused report extra arg
Browse files Browse the repository at this point in the history
  • Loading branch information
mplatzer authored Feb 13, 2025
1 parent dbd2315 commit a49a5ac
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
4 changes: 0 additions & 4 deletions mostlyai/qa/assets/html/report_template.html
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ <h1 id="summary"><span>{{ meta.report_title }}</span>{{ meta.report_subtitle }}<
Generated on {{ report_creation_datetime.strftime("%d %b %Y, %H:%M") }}
&nbsp;&nbsp;●&nbsp;&nbsp;
{{ "{:,d}".format(meta.rows_original) }} original samples, {{ "{:,d}".format(meta.rows_synthetic) }} synthetic samples
{% if meta.report_extra_info %}
&nbsp;&nbsp;●&nbsp;&nbsp;
{{ meta.report_extra_info }}
{% endif %}
</p>
{% if is_model_report %}
<div class="d-flex">
Expand Down
5 changes: 1 addition & 4 deletions mostlyai/qa/reporting.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ def report(
report_title: str = "Model Report",
report_subtitle: str = "",
report_credits: str = REPORT_CREDITS,
report_extra_info: str = "",
max_sample_size_accuracy: int | None = None,
max_sample_size_embeddings: int | None = None,
statistics_path: str | Path | None = None,
Expand All @@ -85,7 +84,7 @@ def report(
If the data represents sequential data, provide the `tgt_context_key` to set the groupby column for the target data.
Customize the report with the `report_title`, `report_subtitle`, `report_credits`, and `report_extra_info`.
Customize the report with the `report_title`, `report_subtitle` and `report_credits`.
Limit the compute time used by setting `max_sample_size_accuracy` and `max_sample_size_embeddings`.
Expand All @@ -102,7 +101,6 @@ def report(
report_title: The title of the report.
report_subtitle: The subtitle of the report.
report_credits: The credits of the report.
report_extra_info: The extra information of the report.
max_sample_size_accuracy: The maximum sample size for accuracy calculations.
max_sample_size_embeddings: The maximum sample size for embedding calculations (similarity & distances)
statistics_path: The path of where to store the statistics to be used by `report_from_statistics`
Expand Down Expand Up @@ -326,7 +324,6 @@ def report(
"report_title": report_title,
"report_subtitle": report_subtitle,
"report_credits": report_credits,
"report_extra_info": report_extra_info,
}
statistics.store_meta(meta=meta)
_html_report.store_report(
Expand Down
3 changes: 0 additions & 3 deletions mostlyai/qa/reporting_from_statistics.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ def report_from_statistics(
report_title: str = "Data Report",
report_subtitle: str = "",
report_credits: str = REPORT_CREDITS,
report_extra_info: str = "",
max_sample_size_accuracy: int | None = None,
max_sample_size_embeddings: int | None = None,
update_progress: ProgressCallback | None = None,
Expand All @@ -63,7 +62,6 @@ def report_from_statistics(
report_title: The title of the report.
report_subtitle: The subtitle of the report.
report_credits: The credits of the report.
report_extra_info: The extra information of the report.
max_sample_size_accuracy: The maximum sample size for accuracy calculations.
max_sample_size_embeddings: The maximum sample size for embedding calculations (similarity & distances)
update_progress: The progress callback.
Expand Down Expand Up @@ -155,7 +153,6 @@ def report_from_statistics(
"report_title": report_title,
"report_subtitle": report_subtitle,
"report_credits": report_credits,
"report_extra_info": report_extra_info,
}

# HTML report
Expand Down

0 comments on commit a49a5ac

Please sign in to comment.