From a49a5accf61512bdcf23e42c241fbd781be88e3f Mon Sep 17 00:00:00 2001 From: Michael Platzer Date: Thu, 13 Feb 2025 11:25:11 +0100 Subject: [PATCH] refactor: drop unused report extra arg --- mostlyai/qa/assets/html/report_template.html | 4 ---- mostlyai/qa/reporting.py | 5 +---- mostlyai/qa/reporting_from_statistics.py | 3 --- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/mostlyai/qa/assets/html/report_template.html b/mostlyai/qa/assets/html/report_template.html index 73b6a2f..02b775c 100644 --- a/mostlyai/qa/assets/html/report_template.html +++ b/mostlyai/qa/assets/html/report_template.html @@ -53,10 +53,6 @@

{{ meta.report_title }}{{ meta.report_subtitle }}< Generated on {{ report_creation_datetime.strftime("%d %b %Y, %H:%M") }}   ●   {{ "{:,d}".format(meta.rows_original) }} original samples, {{ "{:,d}".format(meta.rows_synthetic) }} synthetic samples - {% if meta.report_extra_info %} -   ●   - {{ meta.report_extra_info }} - {% endif %}

{% if is_model_report %}
diff --git a/mostlyai/qa/reporting.py b/mostlyai/qa/reporting.py index f01497b..c728ed0 100644 --- a/mostlyai/qa/reporting.py +++ b/mostlyai/qa/reporting.py @@ -68,7 +68,6 @@ def report( report_title: str = "Model Report", report_subtitle: str = "", report_credits: str = REPORT_CREDITS, - report_extra_info: str = "", max_sample_size_accuracy: int | None = None, max_sample_size_embeddings: int | None = None, statistics_path: str | Path | None = None, @@ -85,7 +84,7 @@ def report( If the data represents sequential data, provide the `tgt_context_key` to set the groupby column for the target data. - Customize the report with the `report_title`, `report_subtitle`, `report_credits`, and `report_extra_info`. + Customize the report with the `report_title`, `report_subtitle` and `report_credits`. Limit the compute time used by setting `max_sample_size_accuracy` and `max_sample_size_embeddings`. @@ -102,7 +101,6 @@ def report( report_title: The title of the report. report_subtitle: The subtitle of the report. report_credits: The credits of the report. - report_extra_info: The extra information of the report. max_sample_size_accuracy: The maximum sample size for accuracy calculations. max_sample_size_embeddings: The maximum sample size for embedding calculations (similarity & distances) statistics_path: The path of where to store the statistics to be used by `report_from_statistics` @@ -326,7 +324,6 @@ def report( "report_title": report_title, "report_subtitle": report_subtitle, "report_credits": report_credits, - "report_extra_info": report_extra_info, } statistics.store_meta(meta=meta) _html_report.store_report( diff --git a/mostlyai/qa/reporting_from_statistics.py b/mostlyai/qa/reporting_from_statistics.py index b920499..30cc78d 100644 --- a/mostlyai/qa/reporting_from_statistics.py +++ b/mostlyai/qa/reporting_from_statistics.py @@ -45,7 +45,6 @@ def report_from_statistics( report_title: str = "Data Report", report_subtitle: str = "", report_credits: str = REPORT_CREDITS, - report_extra_info: str = "", max_sample_size_accuracy: int | None = None, max_sample_size_embeddings: int | None = None, update_progress: ProgressCallback | None = None, @@ -63,7 +62,6 @@ def report_from_statistics( report_title: The title of the report. report_subtitle: The subtitle of the report. report_credits: The credits of the report. - report_extra_info: The extra information of the report. max_sample_size_accuracy: The maximum sample size for accuracy calculations. max_sample_size_embeddings: The maximum sample size for embedding calculations (similarity & distances) update_progress: The progress callback. @@ -155,7 +153,6 @@ def report_from_statistics( "report_title": report_title, "report_subtitle": report_subtitle, "report_credits": report_credits, - "report_extra_info": report_extra_info, } # HTML report